Make telemetry batch size configurable and add time-based flush#622
Make telemetry batch size configurable and add time-based flush#622saishreeeee merged 1 commit intomainfrom
Conversation
saishreeeee
requested review from
deeksha-db,
gopalldb,
jackyhu-db,
jayantsing-db,
jprakash-db,
madhav-db,
samikshya-db,
shivam2680 and
vikrantpuppala
as code owners
|
Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase ( |
|
Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase ( |
saishreeeee
removed request for
deeksha-db,
jayantsing-db,
samikshya-db and
shivam2680
|
Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase ( |
|
Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase ( |
|
Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase ( |
|
Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase ( |
|
Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase ( |
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
saishreeeee
force-pushed
the
telemetry-batching
branch
from
f90cd99 to
4f88318
Compare
jprakash-db
left a comment
jprakash-db
left a comment
There was a problem hiding this comment.
LGTM. Thanks for making the changes
3 participants
What type of PR is this?
Description
The flush timer is centralized in
TelemetryClientFactory, single background thread to manage all connections. Keeping it inTelemetryClientwould mean creating a timer thread per connection.Used
threading.Threadwiththreading.Event. Thethreading.Eventacts as a thread-safe shutdown signal, and itswait(timeout)method allows the thread to wait for the next flush interval while remaining immediately responsive to a shutdown command.While
threading.Timercould be used, it would create a new thread every flush interval as we need to create a timer after each execution.How is this tested?
Related Tickets & Documents
design doc
PECOBLR-654